Fall back to a configuration file if role description does not contain config token.#39
Open
renaudhager wants to merge 2 commits intokislyuk:masterfrom
Open
Fall back to a configuration file if role description does not contain config token.#39renaudhager wants to merge 2 commits intokislyuk:masterfrom
renaudhager wants to merge 2 commits intokislyuk:masterfrom
Conversation
… will fall back on a config file if there is no config token present in role description.
Owner
|
Thanks for your contribution! The overall idea here is great, but before this PR can be merged, it must:
|
- Fixed a bug when Role description is empty. - Updated README.md.
e012bb6 to
130c6c2
Compare
|
I also only use cloudformation for role/instance profile creation and cloudformation does not support descriptions. config file seems like a reasonable approach, but I also like the idea of managing everything from within IAM. I wonder if role path may be a better option. /keymaker/... I am just getting started with keymaker and haven't implemented groups yet. When I require groups I may try this branch or try to use role path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keymaker will fall back on a config file if there is no config token present in role description.
See issue #33