Skip to content

improve concurrency in the checkPaths function#267

Closed
alexandear wants to merge 1 commit intokisielk:masterfrom
alexandear:refactor-improve-concurrency
Closed

improve concurrency in the checkPaths function#267
alexandear wants to merge 1 commit intokisielk:masterfrom
alexandear:refactor-improve-concurrency

Conversation

@alexandear
Copy link
Copy Markdown
Contributor

The PR refactors checkPaths implementation.
Previously, we wrote all the packages to the work channel before starting to check them. Now, we check each package as soon as it is added to the work channel.

@kisielk
Copy link
Copy Markdown
Owner

kisielk commented Feb 20, 2025

Do you have any benchmarks or tests that show this makes an improvement? I'm skeptical there would be any noticable difference especially with a buffered channel.

@alexandear
Copy link
Copy Markdown
Contributor Author

Closing as the improvement is not significant.

I ran errcheck on a few large repositories and did not notice any significant improvement in execution time.

@alexandear alexandear closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants