improve concurrency in the checkPaths function#267
Closed
alexandear wants to merge 1 commit intokisielk:masterfrom
alexandear:refactor-improve-concurrency
Closed
improve concurrency in the checkPaths function#267alexandear wants to merge 1 commit intokisielk:masterfrom alexandear:refactor-improve-concurrency
checkPaths function#267alexandear wants to merge 1 commit intokisielk:masterfrom
alexandear:refactor-improve-concurrency
Conversation
Owner
|
Do you have any benchmarks or tests that show this makes an improvement? I'm skeptical there would be any noticable difference especially with a buffered channel. |
Contributor
Author
|
Closing as the improvement is not significant. I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR refactors
checkPathsimplementation.Previously, we wrote all the packages to the
workchannel before starting to check them. Now, we check each package as soon as it is added to theworkchannel.