Open
Conversation
|
Important Review skippedToo many files! This PR contains 212 files, which is 62 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (212)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
stem/packages/stem/lib/src/bootstrap/workflow_app.dart
Lines 669 to 672 in 8b6f030
Preserve ownership when shutting down a borrowed StemApp
StemWorkflowApp.create(..., stemApp: existingApp) and StemApp.createWorkflowApp() are documented as ways to layer workflows onto an existing task app, but shutdown() always calls app.shutdown(). In that shared-app scenario, closing the workflow wrapper will also stop the host worker and dispose any broker/backend resources owned by the original StemApp, which can take down unrelated task processing. This wrapper needs to distinguish between an app it created and one it merely borrowed.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+975
to
983
| final resolvedWorkerConfig = _resolveWorkflowWorkerConfig( | ||
| workerConfig, | ||
| module: StemModule.combine(module: module, modules: modules), | ||
| tasks: tasks, | ||
| continuationQueue: continuationQueue, | ||
| executionQueue: executionQueue, | ||
| ); | ||
| final appInstance = await StemApp.fromClient( | ||
| client, |
There was a problem hiding this comment.
client.module in StemWorkflowApp.fromClient
When callers use the static StemWorkflowApp.fromClient(client: client) helper without re-passing a module, _resolveWorkflowWorkerConfig sees module == null and infers a subscription from only the workflow queues. That subscription is then forwarded into StemApp.fromClient, so any task handlers bundled in client.module on non-default queues are never subscribed, and workflows that enqueue those tasks will stall indefinitely. The instance helper StemClient.createWorkflowApp() already passes this.module, so this inconsistency looks accidental.
Useful? React with 👍 / 👎.
| @@ -73,6 +86,86 @@ class StemWorkflowApp { | |||
| await app.start(); | |||
There was a problem hiding this comment.
StemWorkflowApp.start() fails
start() flips _started to true before awaiting runtime.start() and app.start(), but it never clears that flag on error. If either startup step throws once (for example, a transient broker/store failure), every later start() or lazy startWorkflow() call will believe the app is already running and skip initialization, leaving the instance permanently unusable until it is rebuilt.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.