fix(developer): use correct return values and nullish checks in package-validation 🍒 🏠#15662
Open
mcdurdin wants to merge 1 commit intostable-18.0from
Open
Conversation
…ge-validation 🍒 Turned on strictNullChecks to verify the file and found a few other problems in this file. However, there are many null check errors reported across the kmc-package source which should be addressed in a future patch. (This is a broader problem for the entire Typescript source of Keyman.) Fixes: #15627 Test-bot: skip Build-bot: skip build:developer Cherry-pick-of: #15653
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned on strictNullChecks to verify the file and found a few other problems in this file. However, there are many null check errors reported across the kmc-package source which should be addressed in a future patch. (This is a broader problem for the entire Typescript source of Keyman.)
Fixes: #15627
Test-bot: skip
Build-bot: skip build:developer
Cherry-pick-of: #15653