fix(developer): handle CRLF as CR internally in LDML debugger 🍒 🏠#15660
Open
mcdurdin wants to merge 1 commit intostable-18.0from
Open
fix(developer): handle CRLF as CR internally in LDML debugger 🍒 🏠#15660mcdurdin wants to merge 1 commit intostable-18.0from
mcdurdin wants to merge 1 commit intostable-18.0from
Conversation
While the debugger memo internally uses CRLF, in all references, CRLF should be converted to CR for consistent text manipulation operations. This follows a similar fix in the kmn debugger in #13334. Also addresses review comments from @ermshiperete. Fixes: #15601 Relates-to: #13334 Cherry-pick-of: #15616
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
developer/
developer/ide/
cherry-pick
keymanapp-test-bot
bot
removed
the
user-test-missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the debugger memo internally uses CRLF, in all references, CRLF should be converted to CR for consistent text manipulation operations. This follows a similar fix in the kmn debugger in #13334.
Fixes: #15601
Relates-to: #13334
Cherry-pick-of: #15616
Test-bot: skip