Open
Conversation
Contributor
Kan18
commented
Dec 28, 2022
Kan18
commented
- genotp.lua: allow caps, make usage more clear, increase password length by 2
- util.lua: close stopgap fix for opus icons on newer MC #59, make Util.getVersion return tuple, and new Util.compareVersion and Util.supportsExtChars methods (changes the mentions of Util.getVersion that I could find)
- samba.lua: sanitize labels
- snmp.lua: spreads out discovery message pings, and increases interval
Make genotp more clearly state that the password can be used once but allows permanent access (sorry for not making this clear earlier.) Use a slightly longer password, and allow uppercase characters except for some that could be ambiguous
Prevent labels from having .., /, *, control characters, or quotes (this generally messes things up) and limit them to a reasonable length. We might possibly also want to do this in snmp.lua, I'm not sure if that will break things though
Previously on large server(s), there was an issue where because chunkloaded computers all started up at once, so they all had the same discovery message sending timer. This prevents that by starting each off with a random offset. Also increases the interval for sending messages from 15 s to 30 s, so that messages (which are the same, a lot of the time) get sent less often.
NiftyNarwhal11
approved these changes
Aug 13, 2025
NiftyNarwhal11
left a comment
NiftyNarwhal11
left a comment
There was a problem hiding this comment.
It is now much clearer what a one time password is and prevents characters that would potentially be ambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.