fix: Refresh of A and AAAA records#441
Merged
keepsimple1 merged 1 commit intokeepsimple1:mainfrom Mar 11, 2026
Merged
Conversation
I was observing random flapping for services when browsing for a longer time. I did some debugging and digging. The root cause: when looking for the addr records we didn't normalize the hostname to lowercase, but store the records keyed by the hostname in lowercase.
Contributor
Author
|
I guess it went unnoticed so far, due to actual host-names being lowercase most of the time. |
keepsimple1
approved these changes
Mar 11, 2026
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
LGTM, thanks for your fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was observing random flapping for services when browsing for a longer time. I did some debugging and digging. The root cause: when looking for address records to refresh we didn't normalize the host-name to lowercase, but we store those records keyed by the host-name in lowercase.
In a query example one could observe the following:
I've tracked it down to A / AAAA records not being refreshed, due to the root cause described above.