Refine(autofill): Give bonus for exact host match#515
Open
maederm wants to merge 1 commit intokeepassium:masterfrom
Open
Refine(autofill): Give bonus for exact host match#515maederm wants to merge 1 commit intokeepassium:masterfrom
maederm wants to merge 1 commit intokeepassium:masterfrom
Conversation
- Move howSimiliar into library to make it unit testable - Add unit tests for different matching cases - Add build/ folder to .gitignore Fixes keepassium#480
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @keepassium
I know that you don't accept PRs, but maybe this inspires you to add a ranking bonus for exact domain matches.
This PR doesn't account for protocol.
Fixes #480
Disclaimer: The code changes were mostly generated with AI tooling. I verified the output of the addition to the similarity logic. The unit tests look good to me, but I’m not sure if you’d write them like that. In pytest I would use parametrize for example. I ran the unit tests successfully in the simulator and also verified that they fail if I change the code.
I didn’t change the copyright headers as most of the logic was already there.