Add struct kas::text::ConfiguredDisplay; replace trait Editor with struct#682
Merged
Add struct kas::text::ConfiguredDisplay; replace trait Editor with struct#682
kas::text::ConfiguredDisplay; replace trait Editor with struct#682Conversation
8878bd4 to
a8195f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new abstraction:
kas::text::ConfiguredDisplayis somewhere betweenTextDisplayandTextin that it contains theTextDisplay,TextClass,FontSelector,Rect,Statusetc. but not the actual text (or the text formatter).The text editor
ComponentusesConfiguredDisplayinstead ofTextinternally, allowing the highlighter to be moved out of structEditorComponent. This removes the need for generics here, and thus the motivation for using a trait, allowing a revert of #676 (motivation: simplicity).EditBox,EditFieldanddialog::TextEditnow all deref toTarget = Editor(non-mut only) and havefn edit(..)supporting usage of&mut selfmethods onEditor(this allows correctly callingEditGuard::editandComponent::prepareafterwards).Basic text-drawing fns (using
kas::theme::Text) have been removed fromDrawCx(replaced with methods onText).kas::theme::Textis moved tokas::text::Text.