Merged
Conversation
MatthewMckee4
added
internal
This was referenced Apr 11, 2026
Merging this PR will degrade performance by 12.49%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | karva_benchmark |
22.4 s | 25.6 s | -12.49% |
Comparing test/consolidated-audit (1761045) with main (816cf55)
MatthewMckee4
force-pushed
the
test/consolidated-audit
branch
from
c312ef1 to
ccee0f2
Compare
MatthewMckee4
changed the title
…r coverage Removes two non-snapshot fail-fast tests in basic.rs that duplicated the existing snapshot-based coverage, deletes trivial unit tests in function_kind.rs and a helper-formula test module in orchestration.rs that was testing a copy of the production logic, and adds an integration test covering the last-failed plus filterset workflow.
Adds 32 new integration tests covering CLI flag combinations and orchestration behaviours that were either untested or only had a happy path. The additions are spread across basic, last_failed, configuration, and a new discovery/edge_cases module.
Follow-up to the consolidated audit: converts hand-written assert_eq! assertions in the newly added karva_logging, karva_project, karva_metadata, and karva_cache unit tests to insta inline snapshots where snapshots add value. Single-value primitive checks (booleans, matches!, length counts) and filesystem existence checks are left as-is.
Converts `filter_traceback`, `parse_traceback_line`, `get_traceback_location`, and `calculate_line_range` unit tests to inline snapshots. These assert on multi-line strings and `Option<TracebackLocation>` / `Option<TextRange>` structs where seeing the full parsed shape is much easier to review than hand-built expected values.
The cherry-picked karva_diagnostic insta dev-dep needed a Cargo.lock update that didn't carry across. Path snapshots in karva_project also need to be normalized to forward slashes via a small posix() helper since Windows formats Utf8PathBuf with backslashes.
Clap embeds the binary name in help/error output. On Windows this includes the .exe suffix, causing snapshot mismatches. The test infrastructure already normalizes other platform differences (backslash paths, ANSI codes), so adding one more filter is the natural fix.
MatthewMckee4
force-pushed
the
test/consolidated-audit
branch
from
cb6800f to
8badc5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds integration tests for CLI flag parsing, configuration discovery, test discovery edge cases,
--last-failedinteractions, and filter expressions. Also adds unit tests tokarva_metadata,karva_cache,karva_project, andkarva_logging. Removes a handful of tests that duplicated existing snapshot coverage.Test Plan
just testuvx prek run -a