Skip to content

#203 Added POSTGRES_SERVER_NAME to ACI create command#204

Merged
jathavaan merged 1 commit intomainfrom
bugfix/203-add-missing-env-variables-in-aci-script
Apr 7, 2026
Merged

#203 Added POSTGRES_SERVER_NAME to ACI create command#204
jathavaan merged 1 commit intomainfrom
bugfix/203-add-missing-env-variables-in-aci-script

Conversation

@jathavaan
Copy link
Copy Markdown
Collaborator

This pull request primarily refactors the main.py file to improve code readability and maintain consistency in formatting. The changes focus on reformatting function definitions and command lists for better clarity, as well as minor style fixes. There are no functional changes to the logic or behavior of the code.

Formatting and readability improvements:

  • Reformatted all multi-argument function definitions and calls to use multi-line style, improving readability when there are several parameters. [1] [2] [3] [4] [5]
  • Reformatted all Azure CLI command lists to use one argument per line, making it easier to see and modify command parameters. [1] [2] [3] [4] [5]
  • Reformatted logger statements and other long lines to use multi-line formatting for better readability. [1] [2] [3]

Minor style and consistency fixes:

  • Changed the file entry point check from single to double quotes for consistency (if __name__ == "__main__":).
  • Added a missing environment variable (POSTGRES_SERVER_NAME) to the container creation command.

@jathavaan jathavaan self-assigned this Apr 7, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 11:31
@jathavaan jathavaan linked an issue Apr 7, 2026 that may be closed by this pull request
@jathavaan jathavaan enabled auto-merge April 7, 2026 11:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reformats main.py for readability (multi-line function calls/definitions and Azure CLI command lists) and updates the Azure Container Instances creation command to pass POSTGRES_SERVER_NAME into the benchmark runner container.

Changes:

  • Reflowed long function signatures/calls and logger statements for consistent multi-line formatting.
  • Reformatted Azure CLI command argument lists to one-argument-per-line.
  • Added POSTGRES_SERVER_NAME to the az container create --environment-variables list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jathavaan jathavaan merged commit 101cfd0 into main Apr 7, 2026
32 checks passed
@jathavaan jathavaan deleted the bugfix/203-add-missing-env-variables-in-aci-script branch April 7, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing env variables in ACI script

2 participants