Add stopRunning call to AudioRecordingService#51
Open
koc-Z3 wants to merge 1 commit intokaransinghgit:mainfrom
Open
Add stopRunning call to AudioRecordingService#51koc-Z3 wants to merge 1 commit intokaransinghgit:mainfrom
koc-Z3 wants to merge 1 commit intokaransinghgit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In hold mode, the orange mic indicator in the menu bar stays on
permanently after transcription completes. The mic is never released
until the app is quit and relaunched.
Root Cause
AVCaptureSession is started in startRecording() but stopRecording()
never calls captureSession?.stopRunning(). The audio writers are
finalized correctly but the hardware mic stays open indefinitely,
causing macOS to keep the orange indicator on.
Fix
Added captureSession?.stopRunning() in the finishGroup.notify callback
in stopRecording(), after the asset writers finish. The session restart
on the next recording is already handled by the existing code in
startRecording().
Tested on