Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

WIP documentation of the WebAuthn signature payload#1314

Draft
imalsogreg wants to merge 5 commits intomasterfrom
greg/webauthn-docs
Draft

WIP documentation of the WebAuthn signature payload#1314
imalsogreg wants to merge 5 commits intomasterfrom
greg/webauthn-docs

Conversation

@imalsogreg
Copy link
Contributor

@imalsogreg imalsogreg commented Oct 30, 2023

@EnoF what do you think? Is this clear enough?

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Contributor

@0xd34df00d 0xd34df00d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text styling nits, please feel free to ignore any!

imalsogreg and others added 2 commits December 12, 2023 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants