This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Add jose for verifying signatures (temporary, WIP, etc)#1165
Draft
edmundnoble wants to merge 7 commits intomasterfrom
Draft
Add jose for verifying signatures (temporary, WIP, etc)#1165edmundnoble wants to merge 7 commits intomasterfrom
edmundnoble wants to merge 7 commits intomasterfrom
Conversation
|
I've added the following tests: I think the When converted to a byte array the length of authenticator is |
|
The above mentioned tests are incorrect, made some copy paste errors for the values... resulting in the false negatives. Below are the rectified tests: |
- otherwise I get a penalty of 1M gas cost, which prevents me from testing the full e2e flow Co-authored-by: Andy Tang <andy.tang@action.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.