Open
Conversation
kevinmeijer97
changed the title
BobWez98
approved these changes
Mar 10, 2026
| $taxonomyValue = $template->get('use_for_taxonomy'); | ||
|
|
||
| if (! $taxonomyValue) { | ||
| $taxonomyValue = $template->use_for_taxonomy; /** @phpstan-ignore-line */ |
Collaborator
There was a problem hiding this comment.
isn't doing
$template->get('use_for_taxonomy'); on line 108 exactly the same as $template->use_for_taxonomy
Member
Author
There was a problem hiding this comment.
Sadly no, $template->get('use_for_taxonomy'); gets the raw value which in this case is a string.
Calling it directly through $template->use_for_taxonomy gives us the actuall Collection object.
I couldn't get the tests & phpstan to work with only using $template->use_for_taxonomy so thats why i ended up with this.
| if (! $collection instanceof Collection) { | ||
| return 0; | ||
| } | ||
| // @codeCoverageIgnoreEnd |
Member
Author
There was a problem hiding this comment.
Couldn't really get this to work in my tests
indykoning
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So added tests and fixed alot of phpstan + pint errors.
Going forward it should be pretty maintainable, should've done this sooner though!