fix: use locales from shared-codebase by Shivam25092001 · Pull Request #1391 · juspay/hyperswitch-web

Shivam25092001 · 2026-02-17T09:06:46Z

Type of Change

Description

This change aims to usage of locales from shared-code-utils and hosted as a common resource on s3.
Related changes at shared-code-utils here: https://github.com/juspay/hyperswitch-sdk-utils/pull/41/changes.

Changed

The locales will be consumed from shared-code and fetched from s3 at runtime for required language. Default english locale files are shipped along with the bundle.

Motivation

By this change, we aim to conform to a single source of truth for all the texts appeared on ui to behave the same across all the sdks/ platforms.

STACKED PRs

How did you test it?

Created a build with shared-code on branch fix-locale-selection.
Inspected the network tab to see if the locale was fetched.

Screenshots / Recordings

Screen.Recording.2026-02-23.at.4.27.51.PM.mov

Checklist

I ran npm run re:build
I reviewed submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2026-02-17T09:06:49Z

Review changes with

Changed Files

File	Status
src/CardTheme.res	Unsupported file format
src/CardUtils.res	Unsupported file format
src/Components/BillingNamePaymentInput.res	Unsupported file format
src/Components/FullNamePaymentInput.res	Unsupported file format
src/Components/GiftCards.res	Unsupported file format
src/Components/SaveDetailsCheckbox.res	Unsupported file format
src/Components/SurchargeUtils.res	Unsupported file format
src/Components/Terms.res	Unsupported file format
src/FormViewJourney.res	Unsupported file format
src/FormViewTabs.res	Unsupported file format
src/LocaleStrings/ArabicLocale.res	Unsupported file format
src/LocaleStrings/CatalanLocale.res	Unsupported file format
src/LocaleStrings/ChineseLocale.res	Unsupported file format
src/LocaleStrings/ConstantStrings.res	Unsupported file format
src/LocaleStrings/DeutschLocale.res	Unsupported file format
src/LocaleStrings/DutchLocale.res	Unsupported file format
src/LocaleStrings/EnglishGBLocale.res	Unsupported file format
src/LocaleStrings/EnglishLocale.res	Unsupported file format
src/LocaleStrings/FrenchBelgiumLocale.res	Unsupported file format
src/LocaleStrings/FrenchLocale.res	Unsupported file format
src/LocaleStrings/HebrewLocale.res	Unsupported file format
src/LocaleStrings/ItalianLocale.res	Unsupported file format
src/LocaleStrings/JapaneseLocale.res	Unsupported file format
src/LocaleStrings/LocaleStringHelper.res	Unsupported file format
src/LocaleStrings/LocaleStringTypes.res	Unsupported file format
src/LocaleStrings/PolishLocale.res	Unsupported file format
src/LocaleStrings/PortugueseLocale.res	Unsupported file format
src/LocaleStrings/RussianLocale.res	Unsupported file format
src/LocaleStrings/SpanishLocale.res	Unsupported file format
src/LocaleStrings/SwedishLocale.res	Unsupported file format
src/LocaleStrings/TraditionalChineseLocale.res	Unsupported file format
src/PaymentMethodCollectElement.res	Unsupported file format
src/Payments/CardPayment.res	Unsupported file format
src/Payments/CardVault.res	Unsupported file format
src/Payments/PaymentMethodsRecord.res	Unsupported file format
src/Utilities/PaymentMethodCollectUtils.res	Unsupported file format
src/Utilities/S3Utils.res	Unsupported file format
src/Utilities/Utils.res	Unsupported file format
src/VGSVault/VGSHelpers.res	Unsupported file format
webpack.common.js	0% smaller
webpack.dev.js	0% smaller

github-actions · 2026-02-17T09:08:08Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-17T10:01:03Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-19T15:12:46Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-19T15:18:34Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-20T05:26:36Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-20T06:03:20Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-20T06:06:57Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-20T06:07:06Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-20T06:07:06Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-23T08:28:15Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-23T08:32:14Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-23T08:57:38Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-23T11:01:08Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

aritro2002 · 2026-02-23T12:52:18Z

src/Components/SaveDetailsCheckbox.res

    customMessageForCardTerms
  } else {
-    localeString.cardTerms(business.name)
+    localeString.cardTermsPart1 ++ business.name ++ localeString.cardTermsPart2


please write it using string templates

We tried implementing it using string templates but some string interpolations like surchargeMsgAmount require rendering parts of the text in bold, which involves platform-specific React logic. Since the locale utils are shared between the web and mobile SDKs, adding such rendering logic there isn't feasible.

Because of outliers like this, abstracting string interpolation into shared util functions would be inconsistent — we'd have utils for some cases but not others.

Also, locale strings were split into parts so that consumers can freely decide how to join and display them. Adding a shared util that does the joining for them would defeat that purpose.

aritro2002 · 2026-02-23T13:10:00Z

shortSurchargeMessage
surchargeMsgAmountForCard
surchargeMsgAmount
cardTerms
nameEmptyText
completeNameEmptyText
giftCardPaymentRemainingMessage
sepaDebitTerms
achBankDebitTerms
becsDebitTerms
cardBrandConfiguredErrorText 
formFundsCreditInfoText
formSubheaderAccountText
formHeaderReviewTabLayoutText
formHeaderBankText
formHeaderWalletText
linkRedirectionText
linkExpiryInfo
payoutFromText

I see that you've split several strings into multiple parts (e.g., cardTerms1 and cardTerms2) and are manually concatenating them everywhere using templates like ${cardTerms1}${someValue}${cardTerms2}. The problem with this approach is that it leads to repeated hard-coded logic across multiple files. If something changes in the future, we won’t know which files need to be updated, and this can easily introduce inconsistencies.

Instead, it would be better to create a reusable utility function that handles this logic in one place. This way, we can simply call the function wherever needed, making the code cleaner, easier to maintain, and less error-prone.

aritro2002 · 2026-02-23T13:17:10Z

webpack.dev.js

+    {
+      context: ["/assets/v2/jsons/locales/"],
+      target: "https://beta.hyperswitch.io",
+      changeOrigin: true,
+      secure: true,
+      pathRewrite: {
+        "^/assets/v2/jsons/locales/": "/assets/v2/jsons/locales/",
+      },
+    },


There's no need to add this piece of code to the webpack dev configuration — just keep the target empty; the rest can remain as it is. This is only needed for local testing.

Yes, we'll need this for local testing by creating a proxy to sandbox.

just keep the target empty

Didn't get this. Can you please explain

I meant that we should not hard-code the target URL in the proxy config. Since this is only for local development, anyone who is testing can set their own URL(integ, sbx,prod) if needed. There’s no point in pushing a fixed sandbox or beta endpoint into the public repo.
So instead of keeping "https://beta.hyperswitch.io" in the config, we should leave the target field empty, and developers can fill it locally while testing.

aritro2002 · 2026-02-23T13:39:46Z

src/Utilities/S3Utils.res

+    let json = await response->Fetch.Response.json
+    let localeStrings = LocaleUtils.getLocaleStringsFromJson(json)
+    Console.log2("-- Locale strings fetched from S3: ", localeStrings)
+    localeStrings
+  } else {
+    raise(Exn.raiseError("Failed to fetch locale"))
+  }
+}


Instead of using console.log, please use the logger as used in the API calls in the paymentHelpers.res file

yeah, mb, thanks. Missed the log statement here by mistake

removed the log statement

aritro2002 · 2026-02-23T13:41:55Z

src/CardTheme.res

+  | Some(Ca) => "ca"
+  // | Some(Zh) => "zh" // Pending support
+  | Some(Pt) => "pt"
+  | Some(It) => "it"
+  | Some(Pl) => "pl"
+  | Some(Nl) => "nl"
+  | Some(NI_BE) => "nl-BE" // to check
+  | Some(Sv) => "sv"
+  | Some(Ru) => "ru"
+  // | Some(Zh_HANT) => "zh-Hant" // Pending support
+  | Some(Lt) => "lt"


zh and zh-Hant is used my merchants on prod

yes will add this in a stacked PR, working on that

fix: chinese locale #1400

juspay/hyperswitch-sdk-utils@66366b1

aritro2002 · 2026-02-23T13:47:27Z

src/Components/SurchargeUtils.res

        } else if index === oneClickWalletsArr->Array.length - 1 {
          <>
-            {React.string(`${Utils.nbsp}${localeString.\"and"}${Utils.nbsp}`)}
+            {React.string(`${Utils.nbsp}${localeString.and_}${Utils.nbsp}`)}


why did you change the type \"and" to and_?

will revert this

removed this change

github-actions · 2026-02-25T08:02:21Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

github-actions · 2026-02-26T08:57:54Z

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
Or link it manually using the "Linked issues" panel in the PR sidebar.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

Shivam25092001 had a problem deploying to Testing February 17, 2026 09:06 — with GitHub Actions Failure

github-actions bot assigned Shivam25092001 Feb 17, 2026

Shivam25092001 force-pushed the fix-shared-code-locale branch from 71cb524 to f9ade03 Compare February 19, 2026 15:12

Shivam25092001 had a problem deploying to Testing February 19, 2026 15:12 — with GitHub Actions Failure

Shivam25092001 force-pushed the fix-shared-code-locale branch from f9ade03 to 9d98345 Compare February 20, 2026 05:26

Shivam25092001 had a problem deploying to Testing February 20, 2026 05:26 — with GitHub Actions Failure

fix: use locales from shared-codebase

47504fb

Shivam25092001 force-pushed the fix-shared-code-locale branch from 9d98345 to 47504fb Compare February 20, 2026 06:03

Shivam25092001 had a problem deploying to Testing February 20, 2026 06:03 — with GitHub Actions Failure

Shivam25092001 marked this pull request as ready for review February 20, 2026 06:06

Shivam25092001 requested review from AbhishekChorotiya, ArushKapoorJuspay, aritro2002, sakksham7 and seekshiva as code owners February 20, 2026 06:06

fix: fetch locales from s3 rather than chunk loading

e230426

Shivam25092001 had a problem deploying to Testing February 23, 2026 08:27 — with GitHub Actions Failure

fix: locale

0f6289a

Shivam25092001 had a problem deploying to Testing February 23, 2026 08:57 — with GitHub Actions Failure

aritro2002 reviewed Feb 23, 2026

View reviewed changes

fix: removed debug log and fixed locale type

7901f2d

Shivam25092001 had a problem deploying to Testing February 25, 2026 08:02 — with GitHub Actions Failure

Conversation

Shivam25092001 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Changed

Motivation

STACKED PRs

How did you test it?

Screenshots / Recordings

Checklist

Uh oh!

semanticdiff-com bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 17, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 17, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 19, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 19, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 20, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 20, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 20, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 20, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 20, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 23, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 23, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 23, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

github-actions bot commented Feb 23, 2026

🚫 Missing Linked Issue

✔️ How to fix this

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aritro2002 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shivam25092001 Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shivam25092001 commented Feb 17, 2026 •

edited

Loading

semanticdiff-com bot commented Feb 17, 2026 •

edited

Loading

aritro2002 commented Feb 23, 2026 •

edited

Loading

Shivam25092001 Feb 25, 2026 •

edited

Loading