Skip to content

Add folder share via link#141

Open
MUFFANUJ wants to merge 2 commits intojupyterlab:mainfrom
MUFFANUJ:addFolderSharing
Open

Add folder share via link#141
MUFFANUJ wants to merge 2 commits intojupyterlab:mainfrom
MUFFANUJ:addFolderSharing

Conversation

@MUFFANUJ
Copy link
Copy Markdown
Member

@MUFFANUJ MUFFANUJ commented Apr 3, 2026

closes #132

This update expands share-via-link so users can share both single files and entire folders directly from Plugin Playground. Sharing now works from the editor flow and from file browser right-click actions for both files and folders. Folder sharing includes a guided selection experience when content is too large, so users can choose which files to include and still generate a shareable link.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Preview environments for this pull request:

Preview Lab Notebook v7
Binder Binder Binder Notebook v7
JupyterLite JupyterLite JupyterLite Notebook v7

@MUFFANUJ MUFFANUJ added the enhancement New feature or request label Apr 3, 2026
@MUFFANUJ
Copy link
Copy Markdown
Member Author

MUFFANUJ commented Apr 3, 2026

I was thinking, should we have a show checkboxes dialog always when exporting the folder, or should there be a setting to ask that (show dialog on export something similar false by default), because maybe users might have some files they don't want to include, and in current mindset, they would still share it and dont have a way to exclude it

@krassowski
Copy link
Copy Markdown
Member

should we have a show checkboxes dialog always when exporting the folder

Always by default sounds good to me

should there be a setting to ask that (show dialog on export something similar false by default

Yes, it could be more complex, see below

because maybe users might have some files they don't want to include,

yes, or they may want to include some files that the heuristic would exclude (say .svg for icons, though maybe this should be included by default; maybe .png is more reasonable example, that should be excluded most of the time, but there are legitimate cases when extensions may want to include it)

My current thinking would be, let's add a setting "Show file selection dialog on export" with options:

  • Always
  • When any file would be auto-excluded or if the size limit is hit
  • When size limit is hit

Then, to make sure this is discoverable we could default to "Always" but in the dialog we could add checkbox like:

[ ] Do not ask me again if all files can be included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Add folder sharing support

2 participants