Refactor Api clients to a base implementation#11
Merged
carlosantoniodasilva merged 6 commits intomainfrom Mar 5, 2026
Merged
Conversation
carlosantoniodasilva
force-pushed
the
ca-refactor-api-client
branch
from
78d7216 to
11e828a
Compare
Use the java logging library in core, leave slf4j for the springboot integrations only.
carlosantoniodasilva
force-pushed
the
ca-refactor-api-client
branch
from
11e828a to
5811deb
Compare
`bin/dev` was actually not present in the spring-boot-2-sample, so add it, and fix the Procfile matching the other spring-boot-sample. Cleanup procfile from spring-boot-sample removing commented stuff for running as "render", we never use that and it's been removed from other projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share most of the logic to send reports to our API, but let the individual implementations handle the HTTP layer (the actual HTTP request), and return an "HttpResult"-type object with success vs error.
The bulk of the logic has been moved to the
ApiClientBase(renamed fromApiClient, to matchConfigBase).The original goal was to add retrying, but the java packages already implement it, but now that logic is shared. We can add exponential backoff as a follow-up.
Samples