multipleOf: support negative values#888
Open
ostrowr wants to merge 1 commit intojson-schema-org:mainfrom
Open
Conversation
gregsdennis
approved these changes
Apr 6, 2026
Member
gregsdennis
left a comment
There was a problem hiding this comment.
That looked right according to the spec.
We might consider reducing the positive requirement from multipleOf to just != 0 for the spec. I see no reason it needs to be positive.
Author
I think it's marginally simpler to leave it positive since it reduces the space of equivalent schemas. multipleOf: 1 and multipleOf: -1 are equivalent and so I think it's kind of nice to be opinionated about which one to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec, it's perfectly valid for a negative number to be a multipleOf a positive one:
https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#rfc.section.6.2.1
-4.5/1.5 = -3, which is an integer!
I found this because https://github.com/Stranger6667/jsonschema only admits positive multiples, which I don't think is correct per the spec, but has a 100% pass rate.