Skip to content

chore: redundant function call #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpillora merged 1 commit into from
Oct 12, 2025
Merged

chore: redundant function call #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions handler/handler_execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,11 @@ func (h *Handler) getAssetsNoCache(q Query) (string, Assets, error) {
SHA256: sumIndex[ga.Name],
}

key := asset.Key()
// "linux/", "/amd64" will all be assumed as "linux/amd64"
if assumedLinuxAsset {
cAssetKey := asset.Key()
// "linux/" always win.
if cAssetKey == "linux/" {
if key == "linux/" {
delete(candidates, "/amd64")
foundLinuxAMD64 = true

Expand All @@ -192,11 +192,11 @@ func (h *Handler) getAssetsNoCache(q Query) (string, Assets, error) {
} else if _, exists := candidates["linux/"]; exists {
continue
}
candidates[asset.Key()] = asset
candidates[key] = asset
continue
}

// there can only be 1 file for each OS/Arch
key := asset.Key()
if other, exists := index[key]; exists {
gnu := func(s string) bool { return strings.Contains(s, "gnu") }
musl := func(s string) bool { return strings.Contains(s, "musl") }
Expand Down
Loading