Closed
Conversation
yoyoma2
changed the title
Owner
|
See #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since parentheses are legal characters in uri's, the plugin should accept them. Here's an example that used to fail but now works with "Browse to".
https://m.costco.ca/T-Fal-20.8-L-(22-qt.)-Pressure-Cooker-Canner-.product.100340458.html
Question: If this pull request is accepted in v2 (which is what I use with my version of gedit) will you submit it to the master branch or do I need to make another pull request there?