Conversation
Signed-off-by: joshydavid <cxang.2022@scis.smu.edu.sg>
Signed-off-by: joshydavid <cxang.2022@scis.smu.edu.sg>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: joshydavid <cxang.2022@scis.smu.edu.sg>
There was a problem hiding this comment.
Pull Request Overview
This PR spins down AWS resources by adding a user notification banner and updating frontend dependencies. The changes inform users that the backend is currently unavailable due to AWS resources being spun down.
- Added a reusable banner component system with multiple sub-components
- Updated frontend dependencies including Radix UI packages
- Integrated the banner into the header to display the AWS notice
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Updated dependencies for banner functionality |
| frontend/app/components/ui/button.tsx | Added transparent button variant for banner close button |
| frontend/app/components/ui/banner.tsx | Created comprehensive banner component system |
| frontend/app/components/Header/index.tsx | Integrated AWS notice banner into header |
| frontend/app/components/Banner/index.tsx | Created banner component wrapper |
| </header> | ||
| <> | ||
| <BannerComponent | ||
| title="⚠️ Notice: AWS resources have been spun down. The backend is |
There was a problem hiding this comment.
The HTML entity should not be used in JSX text content. Use a regular space or consider using CSS for spacing control.
| title="⚠️ Notice: AWS resources have been spun down. The backend is | |
| title="⚠️ Notice: AWS resources have been spun down. The backend is |
| title="⚠️ Notice: AWS resources have been spun down. The backend is | ||
| currently not running." |
There was a problem hiding this comment.
The title prop spans multiple lines but appears to be missing the closing quote and continuation. This will cause a syntax error.
| title="⚠️ Notice: AWS resources have been spun down. The backend is | |
| currently not running." | |
| title={`⚠️ Notice: AWS resources have been spun down. The backend is | |
| currently not running.`} |
| setShow: (show: boolean) => void; | ||
| }; | ||
|
|
||
| export const BannerContext = createContext<BannerContextProps>({ |
There was a problem hiding this comment.
[nitpick] The BannerContext is exported but may not need to be public API. Consider making it internal to the banner module unless it's intended for external consumption.
| export const BannerContext = createContext<BannerContextProps>({ | |
| const BannerContext = createContext<BannerContextProps>({ |
|
Description
What type of PR is this?
Desktop and mobile screenshots/recordings