Present distances in km/mi by gerhardol · Pull Request #624 · jonasoreland/runnerup

gerhardol · 2017-08-20T20:31:13Z

Previously 'm' was used in most of the interface
Distances shorter than 1000m are presented in m (also statue, as there is no possibility to set feet/yard).
The Distance picker were previously in whole km/mi with separate meter, now only km/mi
Some hardcoded use of 'm' removed

This replaces PR #458 too

Will require manual checks or rewrite code Adding GraphView twice is done to force two inclusions and 'upgrade' the version of Android support library that GraphView was compiled with twice (GraphView is not used in 2.2 (but 2.3 "Froyo" builds). A wrapper will maybe suppress for Froyo.) TODO: Find how this should be handled without suppressions. The real benefit of a separate PR is to raise awareness. Note: RunnerUp, MapBox, GraphView, Play Services all uses different versions of Support Lib. One solution may be to compile MapBox and GraphView separately and adapt to PlayServices version.... latestCompile - Classpath for compiling the latest sources. +--- com.android.support:design:25.1.0 | +--- com.android.support:support-v4:25.1.0 | | +--- com.android.support:support-compat:25.1.0 | | | \--- com.android.support:support-annotations:25.1.0 | | +--- com.android.support:support-media-compat:25.1.0 | | | +--- com.android.support:support-annotations:25.1.0 | | | \--- com.android.support:support-compat:25.1.0 (*) | | +--- com.android.support:support-core-utils:25.1.0 | | | +--- com.android.support:support-annotations:25.1.0 | | | \--- com.android.support:support-compat:25.1.0 (*) | | +--- com.android.support:support-core-ui:25.1.0 | | | +--- com.android.support:support-annotations:25.1.0 | | | \--- com.android.support:support-compat:25.1.0 (*) | | \--- com.android.support:support-fragment:25.1.0 | | +--- com.android.support:support-compat:25.1.0 (*) | | +--- com.android.support:support-media-compat:25.1.0 (*) | | +--- com.android.support:support-core-ui:25.1.0 (*) | | \--- com.android.support:support-core-utils:25.1.0 (*) | +--- com.android.support:appcompat-v7:25.1.0 | | +--- com.android.support:support-annotations:25.1.0 | | +--- com.android.support:support-v4:25.1.0 (*) | | +--- com.android.support:support-vector-drawable:25.1.0 | | | +--- com.android.support:support-annotations:25.1.0 | | | \--- com.android.support:support-compat:25.1.0 (*) | | \--- com.android.support:animated-vector-drawable:25.1.0 | | \--- com.android.support:support-vector-drawable:25.1.0 (*) | +--- com.android.support:recyclerview-v7:25.1.0 | | +--- com.android.support:support-annotations:25.1.0 | | +--- com.android.support:support-compat:25.1.0 (*) | | \--- com.android.support:support-core-ui:25.1.0 (*) | \--- com.android.support:transition:25.1.0 | +--- com.android.support:support-annotations:25.1.0 | \--- com.android.support:support-v4:25.1.0 (*) +--- com.google.android.gms:play-services-wearable:10.0.1 | +--- com.google.android.gms:play-services-base:10.0.1 | | +--- com.google.android.gms:play-services-basement:10.0.1 | | | \--- com.android.support:support-v4:24.0.0 -> 25.1.0 (*) | | \--- com.google.android.gms:play-services-tasks:10.0.1 | | \--- com.google.android.gms:play-services-basement:10.0.1 (*) | \--- com.google.android.gms:play-services-basement:10.0.1 (*) +--- com.getpebble:pebblekit:4.0.1 +--- com.mapbox.mapboxsdk:mapbox-android-sdk:4.2.0 | +--- com.android.support:support-annotations:23.4.0 -> 25.1.0 | +--- com.android.support:support-v4:23.4.0 -> 25.1.0 (*) | +--- com.android.support:design:23.4.0 -> 25.1.0 (*) | +--- com.squareup.okhttp3:okhttp:3.4.1 | | \--- com.squareup.okio:okio:1.9.0 | +--- com.mapzen.android:lost:1.1.1 | | +--- com.android.support:appcompat-v7:22.2.0 -> 25.1.0 (*) | | +--- com.android.support:support-v4:22.2.0 -> 25.1.0 (*) | | \--- com.google.guava:guava:18.0 | \--- com.mapbox.mapboxsdk:mapbox-java-services:1.3.1 | +--- com.squareup.retrofit2:retrofit:2.1.0 | | \--- com.squareup.okhttp3:okhttp:3.3.0 -> 3.4.1 (*) | +--- com.squareup.retrofit2:converter-gson:2.1.0 | | +--- com.squareup.retrofit2:retrofit:2.1.0 (*) | | \--- com.google.code.gson:gson:2.7 | \--- com.squareup.okhttp3:logging-interceptor:3.3.1 | \--- com.squareup.okhttp3:okhttp:3.3.1 -> 3.4.1 (*) \--- com.jjoe64:graphview:4.2.1 \--- com.android.support:support-v4:22.1.1 -> 25.1.0 (*)

Suppress in code not working with gradle 3.0.0?

Probably bad check, it refers to MapBox

All of the usage I see uses local variables, so a static inner class is not possible. The usage seem to be within the "calling activity" so leak should be minor

Currently those with Lint bugs

Also update Android gradle plugin The preparation has no functional change for AS2.3, but it easier to switch between the versions

Google no longer distributes libs with jcenter(), uses its own repo

No longer required for AS3

…tions # Conflicts: # .gitignore # .travis.yml # app/AndroidManifest.xml # app/latest/java/org/runnerup/feedwidget/FeedWidgetService.java # app/lint-baseline.xml # app/src/org/runnerup/db/DBHelper.java # app/src/org/runnerup/export/DefaultSynchronizer.java # app/src/org/runnerup/export/DigifitSynchronizer.java # app/src/org/runnerup/export/EndomondoSynchronizer.java # app/src/org/runnerup/export/FileSynchronizer.java # app/src/org/runnerup/export/FunBeatSynchronizer.java # app/src/org/runnerup/export/GarminSynchronizer.java # app/src/org/runnerup/export/GoogleFitSynchronizer.java # app/src/org/runnerup/export/RunKeeperSynchronizer.java # app/src/org/runnerup/export/RuntasticSynchronizer.java # app/src/org/runnerup/view/AccountListActivity.java # build.gradle # common/src/main/java/org/runnerup/common/util/Constants.java # hrdevice/src/org/runnerup/hr/HRManager.java # wear/lint-baseline.xml

unused import unused parameters and methods variable can be final access can be private array type init constantconditions A few suppressions

This reverts commit d7d245c.

…tions

To be added when source is released This reverts commit 3f51ea3.

Previously 'm' was used in most of the interface Distances shorter than 1000m are presented in m (also statue, as there is no possibility to set feet/yard). The Distance picker were previously in whole km/mi with separate meter, now only km/mi Some hardcoded use of 'm' removed

gerhardol added 30 commits December 30, 2016 15:00

Merge branch '_pr/remove-unused-resources3' into master-pr

be2c2f0

Merge branch '_pr/centralize-play-version' into master-pr

25b945a

Merge branch '_pr/wear-lint-suppressions' into master-pr

53d9d75

Merge branch '_pr/lint-GradleCompatible-workaround' into master-pr

5a11030

Merge branch '_pr/lint-suspicious-collection-calls' into master-pr

507e90d

Merge branch '_pr/lint-wear-enable-travis' into master-pr

704c46f

Merge branch '_pr/centralize-junit-mockito' into master-pr

d41d063

Merge branch 'viewholder-pattern' into master-pr

1b6d03c

Merge branch '_pr/android-studio-2.3-gradle' into master-pr

3954831

Lint: Various lint suggestions and suppressions

d708e31

Lint: Right-to-left lint suggestions

48931d9

Lint: Using private defined black

7737902

Lint: Specify locale when formatting strings

c76f777

Lint: Hardcoded strings

1f176c0

Lint: static field leak

1d6de6a

Lint: Class and method parameters can be local

7f43db7

Lint: final for private/static does not make sense

07af7f8

Lint: Unnecessary public/private identifier

d87f468

Lint: Declaration access can be weaker

1d1a7a4

Lint: Declaration can be final

7498648

Lint: Override method only calls super

6f2d8bf

Lint: field can be local

0766720

Lint: If statements can be simplified

95a07a2

Lint: return is not needed last in a void method

5f30c46

Lint: Unnecessary boolean expression - simplify

e172ebd

Lint: SuppressWarnings("BooleanMethodIsAlwaysInverted")

073bb9c

Lint: Unnecessary local variable

c692127

Lint: Suppress warnings for empty methods

4559cbf

Lint: Access can be weaker

17147ba

gerhardol added 24 commits July 31, 2017 10:14

Lint: Eliminate CustomViewStyleable for NumberPicker

1bf1c2b

Lint: suppress ClickableViewAccessibility

1856ee9

Suppress in code not working with gradle 3.0.0?

Lint: Eliminate PrivateResource for GoogleFitData

803e4a2

Probably bad check, it refers to MapBox

Lint: Suppress StaticFieldLeak

f3f3e12

All of the usage I see uses local variables, so a static inner class is not possible. The usage seem to be within the "calling activity" so leak should be minor

Lint: Add baseline files, suppressing non interesting issues

48592be

Currently those with Lint bugs

Prepare for Android Studio 3: Add Google repo, set flavorDimension

ae742c8

Also update Android gradle plugin The preparation has no functional change for AS2.3, but it easier to switch between the versions

Add Google repository for app/wear

8c52664

Google no longer distributes libs with jcenter(), uses its own repo

Update build-tools to 26.0.1

abe3d92

Lint: Better solution for support:wearable vs wearable:wearable

9f25f94

Lint: Updated comments for GradleCompatible

5c3b80d

No longer required for AS3

Ignore gen/

1284c80

Various inspect changes

de79cde

unused import unused parameters and methods variable can be final access can be private array type init constantconditions A few suppressions

AS3 Lint, supress StaticTaskLeak

243c48d

ANT+ lib should be provided, not compile

d7d245c

Target Android O

3f51ea3

Lint: Regression for InflateParams in HRSettings

2e95239

Revert "ANT+ lib should be provided, not compile"

5b8ec1d

This reverts commit d7d245c.

Merge branch 'pr/615-hr-settings-noprovider' into pr/524-lint-elimina…

7c83f1d

…tions

Merge remote-tracking branch 'origin/master' into pr/524-lint-elimina…

73f56ab

…tions

Revert "Target Android O"

fc00155

To be added when source is released This reverts commit 3f51ea3.

Merge branch 'master' into pr/524-lint-eliminations

a31b479

Froyo NewApi lint errors

49181d1

This was referenced Aug 20, 2017

Manual distance picker miles #458

Closed

Short distances and elevation with statute units #626

Open

Workout zero repeat crash #625

Merged

gerhardol mentioned this pull request May 9, 2020

Configurable notification #915

Open

gerhardol mentioned this pull request Oct 24, 2020

Inputting the distance in a manual entry is not convenient #979

Open

gerhardol marked this pull request as draft August 31, 2024 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Present distances in km/mi#624

Present distances in km/mi#624
gerhardol wants to merge 140 commits intojonasoreland:masterfrom
gerhardol:pr/km_mi_in_distance-picker

gerhardol commented Aug 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gerhardol commented Aug 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants