Skip to content

Fix typo in mNotificationsOn and wrong log string in discoverServices()#1331

Merged
jonasoreland merged 2 commits intohr-ble-50from
copilot/sub-pr-1329-again
Mar 7, 2026
Merged

Fix typo in mNotificationsOn and wrong log string in discoverServices()#1331
jonasoreland merged 2 commits intohr-ble-50from
copilot/sub-pr-1329-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 7, 2026

Two small bugs found during code review of the BluetoothLE scan API migration.

Changes

  • Typo fix: mNotifictionsOnmNotificationsOn (field declaration + both usages)
  • Wrong log string: discoverServices() permission check was emitting "btGatt.connect" instead of "btGatt.discoverServices" — misleading when debugging permission failures

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…coverServices()

Co-authored-by: gerhardol <6248932+gerhardol@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 7, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Convert to use Android 5.0 API for BluetoothLE scan Fix typo in mNotificationsOn and wrong log string in discoverServices() Mar 7, 2026
@gerhardol gerhardol marked this pull request as ready for review March 7, 2026 22:02
@jonasoreland jonasoreland merged commit 6b9b1ef into hr-ble-50 Mar 7, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants