feat(config): add support for configuration flags in Context#754
feat(config): add support for configuration flags in Context#754TheoD02 wants to merge 1 commit intojolicode:mainfrom
Conversation
TheoD02
force-pushed
the
feat/context-config-flags
branch
from
99c3d5f to
ba9445b
Compare
- Introduced Config and ConfigFlag classes to manage configuration flags. - Added methods to enable and disable flags. - Implemented deprecation warnings for unconfigured flags.
TheoD02
force-pushed
the
feat/context-config-flags
branch
from
ba9445b to
3ae4071
Compare
| Configuration flags support a deprecation system to help you prepare for future | ||
| versions of Castor. When a flag is not explicitly configured, or when it's | ||
| configured to a value that will change in a future version, Castor will emit | ||
| a deprecation warning. |
There was a problem hiding this comment.
I don't really like this behavior. If I configured the feature A with true and castor will change it to false in next version, I don't wan't to be warned anymore.
That being said, I don't know what to think about this PR yet. The implementation is quite simple, It's cool.
But I'm not sure we need some tooling to handle a use case we met only once from the beginning of castor.
I think you should not invest too much time on this PR, we need to think / discuss about it before.
There was a problem hiding this comment.
I let you discuss it internally, I keep them open, and tell me what to do after or close the PR if we do not want to implement this feature
| - What the future default value will be | ||
| - In which version the default will change | ||
|
|
||
| To avoid these warnings, explicitly configure the flags you use: |
There was a problem hiding this comment.
According to the previous paragraph, it does not
2 participants
Related to : #748