Validate task argument early in loop command#37
Merged
johnnygreco merged 2 commits intomainfrom Mar 14, 2026
Merged
Conversation
The loop command accepted task as Optional[str] but always requires it at runtime, causing a confusing late error deep in the engine. Add early validation that either task or --resume-run is provided before any work begins. Closes #30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runandsubmitsilently proceeded without a task. Those commands were replaced with migration shims in PR Rewrite CLI with purpose-built subcommands #32, but the same problem remained in theloopcommand: it acceptstaskasOptional[str]yet the engine always requires it for loop mode, causing a confusing late error after config loading and banner printing.loopCLI command: errors immediately if neithertasknor--resume-runis provided.pipeis intentionally left with optionaltasksince pipe mode genuinely works without one.Closes #30
Test plan
test_loop_without_task_errorsverifies early error before any engine work