CLI option parser passes empty option strings, causing startup failure

[huyhoang171106]

Summary

Several optparse.OptionParser.add_option(...) calls include "" as an option string (e.g. parser.add_option("", "--load-prev", ...), parser.add_option("-m", "", ...)). optparse validates every option token and rejects empty strings with OptionError during parser setup, which can crash the CLI before argument parsing begins.

Files changed

• pyinstrument/__main__.py (modified)

Testing

• Not run in this environment.

[Copilot]

Pull request overview

Fixes a CLI startup crash caused by invalid optparse option definitions, where empty option strings ("") are passed to OptionParser.add_option(...) and trigger OptionError during parser setup.

Changes:

• Removed empty option-string arguments from several parser.add_option(...) calls in pyinstrument/__main__.py.

Comments suppressed due to low confidence (2)

pyinstrument/main.py:187

• This fix is incomplete: there are still several later parser.add_option("", ...) calls (e.g. for --show-regex, --show-all, --unicode/--no-unicode, --color/--no-color, --use-timing-thread). optparse will still raise OptionError during parser setup as long as any empty option string remains. Please remove the empty-string option token from those remaining calls as well so main() can start up reliably.

    parser.add_option(
        "--show",
        dest="show_fnmatch",
        action="store",
        metavar="EXPR",

pyinstrument/main.py:72

• Please add a regression test that invokes pyinstrument.__main__.main() (or at least builds the OptionParser) to assert it doesn't raise optparse.OptionError during option registration. There are existing CLI tests under test/test_cmdline_main.py, so a small test covering parser construction would prevent this startup-crash regression from returning.

    parser.add_option(
        "--load-prev",
        dest="load_prev",
        action="store",
        metavar="IDENTIFIER",
        help="instead of running a script, load a previous profile session as specified by an identifier",
    )

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.