This repository was archived by the owner on Jan 24, 2020. It is now read-only.
Validate cookie properties in the set method, with more meaningful error messages#80
Open
dlajarretie wants to merge 1 commit intojoeferraro:masterfrom
Open
Validate cookie properties in the set method, with more meaningful error messages#80dlajarretie wants to merge 1 commit intojoeferraro:masterfrom
dlajarretie wants to merge 1 commit intojoeferraro:masterfrom
Conversation
|
with this PR, is it possible to set a session-only cookie by not having expiration date? |
Author
|
It will be possible indeed (only for iOS though, I don't know if the Android implementation allows this already). |
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Apple doc :
I have therefore added some checks to validate that the provided cookie properties match these requirements. This has the added benefit of allowing the creation of cookies when providing only the required properties.
Also took advantage of promises reject blocks to fail cleanly, with meaningful errors that can be caught directly in JS without crashing the native code.