This repository was archived by the owner on Jan 24, 2020. It is now read-only.
Fix crash when expiresDate is nil#121
Open
marcshilling wants to merge 5 commits intojoeferraro:masterfrom
Open
Fix crash when expiresDate is nil#121marcshilling wants to merge 5 commits intojoeferraro:masterfrom
marcshilling wants to merge 5 commits intojoeferraro:masterfrom
Conversation
|
I tested this branch with my app and can confirm that it fixes #120. 👍 Thanks for the help! |
enahum
approved these changes
Apr 25, 2019
enahum
left a comment
enahum
left a comment
There was a problem hiding this comment.
Had to make this change in our fork to solve the crash and it worked beautifully
|
Can we get this merged please? |
|
Thanks! Greetings from 1 year later. |
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120