feat!: Use equivalent for Map and Set getters#153
Merged
jneem merged 1 commit intojneem:mainfrom Feb 17, 2026
Merged
Conversation
DanikVitek
commented
Feb 16, 2026
Comment on lines
267
to
+269
| where | ||
| R: RangeBounds<BK>, | ||
| K: Borrow<BK>, | ||
| BK: Ord + ?Sized, | ||
| R: RangeBounds<Q>, | ||
| Q: Comparable<K> + ?Sized, |
Contributor
Author
There was a problem hiding this comment.
@jneem unfortunately, the API for range now requires to sometimes specify the second type parameter, as it cannot be inferred. Can be seen in tests
Owner
There was a problem hiding this comment.
Huh, I'm a little surprised at that. Thanks for calling it out.
jneem
reviewed
Feb 17, 2026
| .collect(); | ||
| assert_eq!(vec![(7, 8), (5, 6), (4, 5), (3, 4), (2, 3), (1, 2)], range); | ||
| let range: Vec<(i32, i32)> = map.range(&2..&5).map(|(k, v)| (*k, *v)).collect(); | ||
| let range: Vec<(i32, i32)> = map.range(2..5).map(|(k, v)| (*k, *v)).collect(); |
Owner
There was a problem hiding this comment.
This change isn't actually necessary, right? I mean, I think it's a good change, but maybe leave just one Range<&i32> example, just to sanity-check that we're backwards compatible.
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it's either this, or an explicit ::<_, i32> turbofish.
Comment on lines
267
to
+269
| where | ||
| R: RangeBounds<BK>, | ||
| K: Borrow<BK>, | ||
| BK: Ord + ?Sized, | ||
| R: RangeBounds<Q>, | ||
| Q: Comparable<K> + ?Sized, |
Owner
There was a problem hiding this comment.
Huh, I'm a little surprised at that. Thanks for calling it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152