Skip to content

Convert Python 2 code to Python 3 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jncraton merged 6 commits into from
Oct 28, 2025
Merged

Convert Python 2 code to Python 3 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
81e85d3
Initial plan
Copilot Oct 28, 2025
3dfcc61
Convert Python 2 code to Python 3 compatible
Copilot Oct 28, 2025
f45ed98
Complete Python 3 conversion - build now works
Copilot Oct 28, 2025
3af4661
Update GitHub Actions to use Python 3
Copilot Oct 28, 2025
81b4d82
Fix remaining bytes/str issues and update to Ubuntu 22.04
Copilot Oct 28, 2025
0addef5
Remove BUILD_VERIFICATION.md
Copilot Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

steps:
- name: Checkout repository
Expand All @@ -15,8 +15,14 @@ jobs:
with:
node-version: 14

- name: Install python-tk
run: sudo apt-get install --fix-missing python-tk
- name: Install python3-tk
run: sudo apt-get install --fix-missing python3-tk

- name: Run make
run: make

- name: Verify build output
run: |
echo "Build completed successfully"
ls -lh build/aiscript.bin build/patch_rt.mpq
sha256sum build/aiscript.bin build/patch_rt.mpq
6 changes: 3 additions & 3 deletions makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ build/patch_rt.mpq: build/aiscript.bin
maps: build/aiscript.bin
@echo Creating Maps
@truncate -s 64050 build/aiscript.bin
@python2 tools/eud_write_bin.py
@python3 tools/eud_write_bin.py

triggers: build/aiscript.bin
@echo Creating triggers
@python2 tools/eud_gen_trigs.py
@python3 tools/eud_gen_trigs.py

build/aiscript.bin: build/combined.pyai
@echo Creating script binaries
@python2 tools/PyAI.pyw --compile --hidewarns ../$< ../$@ ../build/bwscript.bin
@python3 tools/PyAI.pyw --compile --hidewarns ../$< ../$@ ../build/bwscript.bin
@echo aiscript.bin size:
@wc -c < $@

Expand Down
Loading