THREESCALE-8916: Make strong passwords mandatory#3
Draft
jlledom wants to merge 105 commits intoTHREESCALE-12174-remove-pass-migrationfrom
Draft
THREESCALE-8916: Make strong passwords mandatory#3jlledom wants to merge 105 commits intoTHREESCALE-12174-remove-pass-migrationfrom
jlledom wants to merge 105 commits intoTHREESCALE-12174-remove-pass-migrationfrom
Conversation
8c93fc8 to
da18ea7
Compare
33fe198 to
25f4a95
Compare
…le/porta into THREESCALE-12200_clean_up_helpers_0
0581d50 to
084bfd5
Compare
THREESCALE-12239: Remove unused npm packages
…helpers_0 🧹 Clean up helpers part 0
525653e to
b6fde4e
Compare
…ass-migration THREESCALE-12174: Remove old password migration
This is to ensure that the error is visible on the UI form
⚰️ Remove dead code related to plans widgets
…dation THREESCALE-11219: Fix ActiveDoc issues with server URLs with variables
- But skip validation
Let tests fail to get the complete list of outdated tests
* For unmigrated users to recover a password
Except on the User drop for liquid templates
This reverts commit 746bec2.
1138886 to
bc746e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, a provider can enforce strong password for the developer portal, and weak passwords are accepted by default. About admin portal, there's no option to enable strong passwords, weak passwords are always accepted.
I think both situations make no sense. I don't think it's acceptable to allow users decide whether they enforce strong passwords or not, as long as strong passwords are possible, that should be the default. And same thing about admin portal.
In this PR, I remove any option to accept weak passwords in both admin or developer portals. Existing passwords will continue to work, but new passwords will be enforced to be strong. Also, I increased the minimal number of characters to 16.
This affects multiple screens, but also API endpoints, this is the complete list:
Besides, while doing this, I found a few UI errors that I told Claude to fix. This are the affected screens:
Another thing I noticed is strong passwords, even when enabled, were not being enforced for users not created by a human. For instance, the default admin user created when a buyer is created was always accepting weak passwords no matter the setting. I also fixed this.
Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-8916
Verification steps
You can go through any (ideally all) screens above an try to set a weak password. Also tests should pass.