Skip to content

Features/cli keygen#26

Merged
jjrdk merged 17 commits intomasterfrom
features/cli-keygen
Mar 25, 2026
Merged

Features/cli keygen#26
jjrdk merged 17 commits intomasterfrom
features/cli-keygen

Conversation

@jjrdk
Copy link
Copy Markdown
Owner

@jjrdk jjrdk commented Mar 25, 2026

Add command to generate keys from CLI

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new generate-keys command to opencertserver.cli and introduces BDD coverage to validate keypair generation outputs/paths.

Changes:

  • Adds generate-keys CLI command (RSA/ECDSA) with output-path resolution and PEM file writing.
  • Adds new Reqnroll feature + step assertions to validate generated key files exist and match.
  • Adjusts certificate loading/validation in existing CLI commands (EST enroll, sign-csr).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/opencertserver.cli.tests/StepDefinitions/OpenCertServerCliStepDefinitions.cs Adds placeholder handling for key output paths, serializes CLI execution, and adds keypair match assertions.
tests/opencertserver.cli.tests/Features/GenerateKeys.feature New BDD scenarios for RSA/ECDSA key generation and shared --out prefix behavior.
tests/opencertserver.cli.tests/Features/GenerateKeys.feature.cs Auto-generated Reqnroll binding for the new feature.
src/opencertserver.cli/Program_GenerateKeys.cs Implements generate-keys command and supporting helpers (path derivation, key generation, file output).
src/opencertserver.cli/Program.cs Registers the new command with the root command.
src/opencertserver.cli/Program_EstEnroll.cs Changes client certificate loading logic for mTLS.
src/opencertserver.cli/Program_SignCsr.cs Tweaks CSR subject validation condition.
Files not reviewed (1)
  • tests/opencertserver.cli.tests/Features/GenerateKeys.feature.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jjrdk jjrdk merged commit 71a84c7 into master Mar 25, 2026
2 checks passed
@jjrdk jjrdk deleted the features/cli-keygen branch March 25, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants