Correctly handle Unicode paths on Windows#54
Open
polter-rnd wants to merge 1 commit intojimporter:masterfrom
Open
Correctly handle Unicode paths on Windows#54polter-rnd wants to merge 1 commit intojimporter:masterfrom
polter-rnd wants to merge 1 commit intojimporter:masterfrom
Conversation
Signed-off-by: Pavel Artsishevsky <polter.rnd@gmail.com>
7f2297e to
3d8a743
Compare
Owner
|
Thanks for noticing this (and sorry about the delays in responding). I think we'll need somewhat more extensive changes here though for everything to work nicely. For one thing, it would probably help to switch from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on Windows it's not possible to run tests using either
mettle.exeor subprocess test runner if the path contains unicode characters.It happens because
CreateProcessAandGetModuleFileNameAare not Unicode-aware.The right way is to use generic function prototypes and let the preprocessor choose -
Aor -Wfunction version depending on theUNICODEdefinition as described here.Also added
UNICODEdefinition by default to build.bfg on Windows platform.Fixes #55