Added environment variable support for indices and environment#84
Merged
shraddha5718 merged 5 commits intomasterfrom Sep 23, 2025
Merged
Added environment variable support for indices and environment#84shraddha5718 merged 5 commits intomasterfrom
shraddha5718 merged 5 commits intomasterfrom
Conversation
- Add target_platform and request_timeout parameters to match Datadog approach - Use token parameter instead of password for proper authentication - Update both fluent.conf.rt and fluent.conf.xray - Update Helm values to use feature branch - Use placeholder token in jfrog_helm.env
This reverts commit 1e2c05e.
deepakkjfrog
changed the title
helm/artifactory-ha-values.yaml
Outdated
| - > | ||
| mkdir -p {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/; | ||
| curl https://raw.githubusercontent.com/jfrog/log-analytics-splunk/master/fluent.conf.rt -o {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/fluentd.conf | ||
| curl https://raw.githubusercontent.com/jfrog/log-analytics-splunk/feature/JOBS-1114/fluent.conf.rt -o {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/fluentd.conf |
Collaborator
There was a problem hiding this comment.
This is testing change - pls revert to master
helm/artifactory-values.yaml
Outdated
| - > | ||
| mkdir -p {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/; | ||
| curl https://raw.githubusercontent.com/jfrog/log-analytics-splunk/master/fluent.conf.rt -o {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/fluentd.conf; | ||
| curl https://raw.githubusercontent.com/jfrog/log-analytics-splunk/feature/JOBS-1114/fluent.conf.rt -o {{ .Values.artifactory.persistence.mountPath }}/etc/fluentd/fluentd.conf; |
Collaborator
|
Can we make the change to use -
|
deepakkjfrog
force-pushed
the
feature/JOBS-1114
branch
2 times, most recently
from
46abd31 to
bab9e89
Compare
fluent.conf.xray
Outdated
| metric_value_key value | ||
| insecure_ssl "#{ENV['SPLUNK_INSECURE_SSL']}" | ||
| gzip_compression "#{ENV['SPLUNK_COMPRESS_DATA']}" | ||
| <buffer> |
Collaborator
Author
There was a problem hiding this comment.
These changes are not relevant. Removed.
fluent.conf.rt
Outdated
| metric_value_key value | ||
| insecure_ssl "#{ENV['SPLUNK_INSECURE_SSL']}" | ||
| gzip_compression "#{ENV['SPLUNK_COMPRESS_DATA']}" | ||
| <buffer> |
Collaborator
Author
There was a problem hiding this comment.
These changes are not relevant. Removed.
deepakkjfrog
force-pushed
the
feature/JOBS-1114
branch
from
bab9e89 to
278c0c3
Compare
|
@deepakkjfrog can we add proper commit message which is short and crisp. For example the commit message for this one could be, |
deepakkjfrog
changed the title
prathyu1729
approved these changes
Sep 23, 2025
shraddha5718
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the index names for log and metrics are hardcoded, now its configurable
So we support two additional param in env now:
The logs are flowing and the index it is flowing to is the one which we configured:
The metrics are also shipped and the index it is flowing to is the one which we configured: