fix(fake-timers): convert Date to milliseconds before passing to @sinonjs/fake-timers#16029
Open
Gdhanush-13 wants to merge 1 commit intojestjs:mainfrom
Open
fix(fake-timers): convert Date to milliseconds before passing to @sinonjs/fake-timers#16029Gdhanush-13 wants to merge 1 commit intojestjs:mainfrom
Gdhanush-13 wants to merge 1 commit intojestjs:mainfrom
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
…onjs/fake-timers Since @sinonjs/fake-timers@15.3.0, setSystemTime() only accepts milliseconds (number), not Date objects. Jest's setSystemTime() API accepts both number and Date, so we need to convert Date to milliseconds via .getTime() before forwarding to the underlying clock. Also fixes the same issue in _toSinonFakeTimersConfig() where the config 'now' option (which can be a Date) is passed directly. Closes jestjs#16028
d968be9 to
9d5084c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16028
Problem
Since
@sinonjs/fake-timers@15.3.0,clock.setSystemTime()only accepts milliseconds (number), throwingTypeError: now should be milliseconds since UNIX epochwhen aDateobject is passed.Jest's
setSystemTime()API accepts bothnumber | Date, but forwards the value directly to@sinonjs/fake-timerswithout conversion.Fix
Convert
Dateobjects to milliseconds via.getTime()before passing to the underlying sinon clock in two places:setSystemTime()- the public API called by users_toSinonFakeTimersConfig()- where thenowconfig option is passed duringuseFakeTimers()