Skip to content

Remove redundant test assertion#236

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:remove-redundant-test-assertion
Mar 25, 2026
Merged

Remove redundant test assertion#236
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:remove-redundant-test-assertion

Conversation

@MarkEWaite
Copy link
Contributor

Remove redundant test assertion

Existing assertions already check that the credential usage tracking is correct. This assertion adds no real value to the test.

Part of the fix for issue:

Detected in plugin BOM pull request:

Testing done

  • Confirmed that tests pass with older credentials plugin and with latest credentials plugin.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…plugin

Existing assertions already check that the credential usage tracking
is correct.  This assertion adds no real value to the test.

Testing done:

* Confirmed that tests pass with older credentials plugin and with latest
  credentials plugin.
@MarkEWaite MarkEWaite requested a review from a team as a code owner March 25, 2026 18:38
@MarkEWaite MarkEWaite added tests developer Pull requests that improve developer experience and removed developer Pull requests that improve developer experience labels Mar 25, 2026
@MarkEWaite MarkEWaite merged commit 6b83f38 into jenkinsci:master Mar 25, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant