Skip to content

fix: valid app name for docker registry#826

Open
ankitm123 wants to merge 1 commit intojenkins-x-plugins:mainfrom
ankitm123:valid-app-name
Open

fix: valid app name for docker registry#826
ankitm123 wants to merge 1 commit intojenkins-x-plugins:mainfrom
ankitm123:valid-app-name

Conversation

@ankitm123
Copy link
Copy Markdown
Contributor

@ankitm123 ankitm123 commented Dec 27, 2021 •
edited
Loading

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

jenkins-x-bot commented Dec 27, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
fix: valid app name for docker registry
d509459 
Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitm123
Copy link
Copy Markdown
Contributor Author

ankitm123 commented Dec 27, 2021

/hold

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

jenkins-x-bot commented Dec 27, 2021 •
edited
Loading

@ankitm123: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint d509459 link /test lint
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

APP_NAME is set to an invalid value

2 participants

@ankitm123 @jenkins-x-bot