Skip to content

chore(deps): Update remaining dependencies (closes #43, #50, #51)#54

Merged
jefrnc merged 1 commit intomainfrom
chore/remaining-dependency-updates
Apr 2, 2026
Merged

chore(deps): Update remaining dependencies (closes #43, #50, #51)#54
jefrnc merged 1 commit intomainfrom
chore/remaining-dependency-updates

Conversation

@jefrnc
Copy link
Copy Markdown
Owner

@jefrnc jefrnc commented Apr 2, 2026

Summary

Applies the 3 remaining dependabot updates that had merge conflicts:

Test plan

  • CI pipeline passes (tests + docker build)

- pytest-asyncio 1.1 -> 1.2 (closes #43)
- fastapi 0.116 -> 0.120 (closes #51)
- python 3.13 -> 3.14 (closes #50)
Copilot AI review requested due to automatic review settings April 2, 2026 14:37
@jefrnc jefrnc merged commit d3b4eaf into main Apr 2, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves outstanding Dependabot merge conflicts by updating pinned dependency versions and bumping the Docker base image Python version used for the runtime container.

Changes:

  • Bump fastapi from 0.116.*0.120.* in requirements.txt.
  • Bump pytest-asyncio from 1.1.*1.2.* in requirements-dev.txt.
  • Bump Docker base image from python:3.13-slim-bookwormpython:3.14-slim-bookworm.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
requirements.txt Updates the FastAPI pin to the newer minor version.
requirements-dev.txt Updates the pytest-asyncio pin for dev/test tooling.
Dockerfile Moves the runtime container to Python 3.14.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to 4
FROM python:3.14-slim-bookworm

# Install system dependencies
RUN apt-get update && apt-get install -y \
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the base image bumped to Python 3.14, the build should fail if requirements installation fails. The Dockerfile currently ignores pip install -r /tmp/requirements.txt failures (|| true), which can produce an image missing runtime dependencies and make Python-version incompatibilities hard to detect. Remove the || true (or otherwise handle failures explicitly) so dependency install errors fail the build.

Copilot uses AI. Check for mistakes.
@@ -1,4 +1,4 @@
FROM python:3.13-slim-bookworm
FROM python:3.14-slim-bookworm
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI currently uses Python 3.9 in GitHub Actions workflows, while the runtime Docker image is being bumped to Python 3.14. To reduce risk of runtime-only breakages, consider adding CI coverage for 3.14 (or a version matrix including 3.14) and/or a job that builds the Docker image as part of the PR checks.

Suggested change
FROM python:3.14-slim-bookworm
FROM python:3.9-slim-bookworm

Copilot uses AI. Check for mistakes.
@jefrnc jefrnc deleted the chore/remaining-dependency-updates branch April 2, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants