Skip to content

feat: use bgfx::TransientVertexBuffer / TransientIndexBuffer#35

Draft
simsaens wants to merge 1 commit intojdryg:masterfrom
twolivesleft:feature/bgfx-transient-buffers
Draft

feat: use bgfx::TransientVertexBuffer / TransientIndexBuffer#35
simsaens wants to merge 1 commit intojdryg:masterfrom
twolivesleft:feature/bgfx-transient-buffers

Conversation

@simsaens
Copy link
Copy Markdown
Contributor

@simsaens simsaens commented Aug 8, 2024

Opening this as a draft, this is @JohnTM's original change to vg-renderer to use bgfx transient buffers. Will work with John to write a better PR description

@simsaens simsaens changed the title Use bgfx::TransientVertexBuffer / TransientIndexBuffer feat: use bgfx::TransientVertexBuffer / TransientIndexBuffer Aug 8, 2024
@jdryg
Copy link
Copy Markdown
Owner

jdryg commented Aug 9, 2024

I'd suggest putting all those changes inside preprocessor blocks (e.g. #if VG_CONFIG_USE_TRANSIENT_BUFFERS) in order not to break existing functionality. You might also want to hide (#if !VG_CONFIG_USE_TRANSIENT_BUFFERS) GPUVertexBuffer and GPUIndexBuffer and all code which use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants