Fix vehicle list not refreshing after delete#199
Merged
javedh-dev merged 1 commit intojavedh-dev:devfrom Mar 26, 2026
Merged
Conversation
Removed stale PIN check that was gating the store refresh call. The PIN feature no longer exists in the codebase, so the refresh was never triggered after deletion. Now calls refreshVehicles() directly, consistent with the create/edit flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170
After deleting a vehicle, the list was not refreshing. The delete handler was calling a local
fetchVehicles()function that contained a stale PIN check — a feature that no longer exists in the codebase — so the refresh was never triggered.Removed the dead code and call
vehicleStore.refreshVehicles()directly, consistent with how the create and edit flows already work.