Skip to content

Upgrade to Flutter 3.10 + minor bug fixes#29

Open
BenPoell wants to merge 5 commits intojakebonk:masterfrom
BenPoell:master
Open

Upgrade to Flutter 3.10 + minor bug fixes#29
BenPoell wants to merge 5 commits intojakebonk:masterfrom
BenPoell:master

Conversation

@BenPoell
Copy link
Copy Markdown

  • fixed problems coming with Flutter 3.10
  • found some null checker exceptions during testing + fixed them
  • unfortunately made a bracket wrong, cause an endless loop but found it in testing + fixed it

}

Widget listWidget = ListView.builder(
physics: ClampingScrollPhysics(),
Copy link
Copy Markdown

@koutja koutja Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add for BoardView customization 2 arguments Key? listViewKey and ScrollPhysics? listViewPhysics
I need these settings to control the offset across entire pages

Widget listWidget = ListView.builder(
      key: listViewKey,
      physics: listViewPhysics ?? const ClampingScrollPhysics() ,
      ...

Example:

    Widget listWidget = ListView.builder(
      key: const PageStorageKey('boardview'),
      physics: const PageScrollPhysics(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @koutja kindly have this PR go in if what you've requested is a new feature it can be done on another PR, some of us depend on this. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants