Open
Conversation
As stateless widget must be immutable, this commit fix these issues by turning all properties to final.
Build method on AutomaticKeepAliveClientMixin is marked with @mustCallSuper. This commit add a super.build() call before any code be executed on build method from BoardView, BoardList and BoardItem.
Local variable headerBackgroundColor was not being used, causing default value for background color (255, 255, 255) to never be used. This commit add a proper null check on header container.
Starting on Flutter 2.5, Google established new standards lint rules for Dart and Flutter (https://medium.com/dartlang/announcing-dart-2-14-b48b9bb2fb67). This commit update the analysis_options.yaml and fix all code to meet these guidelines.
The previous implementarion use onTapDown to start dragging instead of the events "onHorizontalDragStart" and "onVerticalDragStart" provided by GestureDetector. Using onTapDown might confuse users because it requires a few seconds before actually starting the drag and drop event which is not the expected behavior.
ianmaciel
force-pushed
the
feature/drag-and-drop-on-click
branch
from
f658cc4 to
67e0090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementarion use onTapDown to start dragging instead of the events "onHorizontalDragStart" and "onVerticalDragStart" provided by GestureDetector.
Using onTapDown might confuse users because it requires a few seconds before actually starting the drag and drop event which is not the expected behavior (#18).
This pull request also fix lint issues according to new Flutter and Dart rules (https://medium.com/dartlang/announcing-dart-2-14-b48b9bb2fb67);