Add stream-based speed control and unlimited speed support#34
Open
khw315 wants to merge 3 commits intoitschasa:mainfrom
Open
Add stream-based speed control and unlimited speed support#34khw315 wants to merge 3 commits intoitschasa:mainfrom
khw315 wants to merge 3 commits intoitschasa:mainfrom
Conversation
* Implement stream-based upload speed control to dynamically adjust limits based on active stream count. * Add `unlimited` keyword support for schedule and stream configs, propagating correctly to qBittorrent and Transmission. * Update core logic, config parsing, and media server modules to accommodate new throttling modes. * Expand documentation and provide a detailed configuration example.
Removed bold formatting and emojis for a cleaner look, clarified explanations of stream-based speed control, and improved consistency in section headings and examples. This makes the documentation easier to read and more professional.
Owner
|
I personally don't see the need to change the speed like this. Plex/Jellyfin calculates the bandwidth that gets reserved, so why should we try to guess what it is? Unlimited bandwidth only makes sense on the schedule module. When unlimited bandwidth is set, how should media modules remove bandwidth? Infinity minus anything is still infinity, so it would just always stay unlimited I guess? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces stream-based speed control, allowing upload speeds to be set based on the number of active media streams rather than just bandwidth usage. This provides more predictable and customizable speed management, particularly for users running Plex, Jellyfin, Emby, or Tautulli alongside torrent clients (#33).
It also adds support for unlimited upload/download speeds, while maintaining backward compatibility (#32). Updates include configuration files, documentation, and client logic to support these new modes.