Open
Conversation
khalsz
requested review from
SimonPinches,
Yannicked,
deepakmaroo,
maarten-ic and
olivhoenen
as code owners
Contributor
|
Thanks for the fix. Note that v1 and v1.1 will be marked as deprecated in the next release. As discussed in #49, please revert the removal of imas-python for the time being. |
khalsz
force-pushed
the
fix/v1-v1_1-endpoint-bug
branch
from
8e6f6d9 to
eeeb17f
Compare
Contributor
Author
Thank you for the comment. I have now reverted the removal of imas-python. |
olivhoenen
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR help fix the bug in the
/simulationsendpoint of v1 and v1_1. It also help removepython-imasdependency from the main dependency in thepyproject.tomlfile.