Open
Conversation
added 3 commits
May 10, 2019 12:54
- fix test description - remove duplicated Stats constructor check
brody2consult
force-pushed
the
some-stat-test-updates
branch
from
0aa1e20 to
96308ae
Compare
(skipped on "win32" platform)
brody2consult
force-pushed
the
some-stat-test-updates
branch
from
18cdde3 to
bff7fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uid&gidtest fixesStatsconstructor checkuid&gid- now skipped on "win32" platform for Travis CI to passOpen questions:
uid&gidvalues from the statSync call (I removed check of actual values due to differences between my mac and Travis CI). I am not sure if this is relevant or not?statcall does not seem to give us Truthyuidorgidvalues on Windows ("win32" platform), any explanation?uid&gidthe right way or not? (some candid feedback is requested)