Skip to content

Remove CGO build flag#698

Open
friegger wants to merge 5 commits intomainfrom
chore/remove-cgo-build-flag
Open

Remove CGO build flag#698
friegger wants to merge 5 commits intomainfrom
chore/remove-cgo-build-flag

Conversation

@friegger
Copy link
Contributor

@friegger friegger commented Mar 17, 2026

CGO is not required anymore.

This fixes also a problem with the recent release drafter bump.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration to streamline release automation workflows.
    • Modified build environment configuration for improved build consistency.

@friegger friegger requested a review from a team as a code owner March 17, 2026 12:00
@friegger friegger requested a review from lukasfrank March 17, 2026 12:03
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5497dd1-28ce-4c54-ad5b-27a0598d66fc

📥 Commits

Reviewing files that changed from the base of the PR and between 1c36ffd and 0e90d78.

📒 Files selected for processing (3)
  • .github/workflows/release-drafter.yml
  • Dockerfile
  • Makefile

Walkthrough

Changes workflow trigger mechanisms in GitHub Actions and removes CGO environment variable overrides from build and lint commands across Dockerfile and Makefile configurations. The workflow now responds to pull_request events instead of pull_request_target, with conditional gates added for push and manual dispatch workflows.

Changes

Cohort / File(s) Summary
CGO Handling
Dockerfile, Makefile
Removed CGO_ENABLED=0 from Dockerfile Go build commands and CGO_ENABLED=1 from Makefile lint and build commands, altering CGO behavior during build and linting processes.
GitHub Actions Workflow
.github/workflows/release-drafter.yml
Updated trigger from pull_request_target to pull_request event; added conditional gate for drafter step to run on push or workflow_dispatch only.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks the 'Proposed Changes' section and provides minimal detail about what was changed and why. Expand the description to follow the template: add a 'Proposed Changes' section with bullet points detailing the modifications, and include a 'Fixes' reference number if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change—removing CGO build flags from Makefile and Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-cgo-build-flag
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants