Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new playable card (“Begg”) that forces a targeted opponent to give a card, including new UI for selecting a card from a player’s hand and related message/catalog updates.
Changes:
- Add “Begg” card metadata + new localized messages for the action.
- Introduce
ChooseCardViewto let a player select a card from another player’s grouped hand. - Wire the new
beggaction into the card action registry and bump the development version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/messages.json | Adds Begg-related prompts/success messages and a card_with_count formatting string used by card selection UI. |
| resources/info.json | Bumps application version to 1.5.19-development. |
| resources/cards.json | Registers the new begg card definition (title/description/emoji/flags). |
| eggsplode/ui/selections.py | Adds ChooseCardView to select cards from a target player’s hand. |
| eggsplode/ui/init.py | Re-exports ChooseCardView. |
| eggsplode/cards/steal.py | Implements Begg gameplay flow (choose target → nope window → target chooses card). |
| eggsplode/cards/init.py | Adds begg to PLAY_ACTIONS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #133