Merged
Conversation
zerline
pushed a commit
to sagemath/sage-combinat-widgets
that referenced
this pull request
Oct 24, 2018
zerline
approved these changes
Oct 24, 2018
zerline
left a comment
zerline
left a comment
There was a problem hiding this comment.
This way, a derived class still belongs to the same module after adding traits.
zerline
approved these changes
Feb 10, 2019
zerline
left a comment
zerline
left a comment
There was a problem hiding this comment.
Helps a lot. Will it be merged soon?
Contributor
Author
|
@minrk I think we should merge this. What is your preferred merge strategy? |
Member
|
Closed and reopened to trigger CI, lgtm |
Carreau
added
5.0-re-review
Carreau
removed
the
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #500. The
reprforself.__class__is not identical after callingadd_traits. This PR copies the__module__and__qualname__from the original class to the new one.