Fix overriding _trait_default method#436
Merged
minrk merged 5 commits intoipython:masterfrom Aug 10, 2017
Merged
Conversation
`has_trait` function is not defined
Prevents modifying classes from behaving as expected - magic method has highest priority, if defined - truncate mro walk at trait.this_trait
minrk
force-pushed
the
test-override-magic-method
branch
from
1f14c60 to
036a909
Compare
Carreau
added
5.0-re-review
Carreau
added
5.0-no-incidence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering generators during class initialization prevents overriding these after the fact.
Move the logic to default resolution, rather than explicitly registering on every construction,
which doesn't allow expected behavior when modifying class or instance objects.